Alona Kaplan has posted comments on this change. Change subject: engine: add GetManagementNetworkCandidates query ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/38042/5/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/predicate/ExternalNetworkPredicateTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/predicate/ExternalNetworkPredicateTest.java: Line 18: private Predicate<Network> underTest = new ExternalNetworkPredicate(); Line 19: Line 20: @Test Line 21: public void testEvalPositive() { Line 22: Mockito.when(mockNetwork.isExternal()).thenReturn(true); Please add static import Line 23: Line 24: Assert.assertTrue(underTest.eval(mockNetwork)); Line 25: } Line 26: Line 20: @Test Line 21: public void testEvalPositive() { Line 22: Mockito.when(mockNetwork.isExternal()).thenReturn(true); Line 23: Line 24: Assert.assertTrue(underTest.eval(mockNetwork)); same Line 25: } Line 26: Line 27: @Test Line 28: public void testEvalNegative() { -- To view, visit https://gerrit.ovirt.org/38042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefca8da3ebfda845af1768aaa3bbc827f698cdcb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
