Eli Mesika has posted comments on this change. Change subject: engine: CRUD actions for HostNicVfsConfig ......................................................................
Patch Set 14: (2 comments) https://gerrit.ovirt.org/#/c/35948/14/packaging/dbscripts/upgrade/03_06_1060_add_host_nic_vfs_config_table.sql File packaging/dbscripts/upgrade/03_06_1060_add_host_nic_vfs_config_table.sql: Line 1: -- Clear all the data from host_device table Line 2: DELETE FROM host_device; Don't you want to use a CASCADE here ??? Line 3: Line 4: -- ---------------------------------------------------------------------- Line 5: -- table host_nic_vfs_config Line 6: -- ---------------------------------------------------------------------- Line 8: CREATE TABLE host_nic_vfs_config Line 9: ( Line 10: id UUID NOT NULL, Line 11: nic_id UUID NOT NULL, Line 12: all_networks_allowed BOOLEAN NOT NULL, we used to prefix booleans with is_ Line 13: _create_date TIMESTAMP WITH TIME ZONE default LOCALTIMESTAMP, Line 14: _update_date TIMESTAMP WITH TIME ZONE default NULL Line 15: ); Line 16: -- To view, visit https://gerrit.ovirt.org/35948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I022a1d19d935832a8baae41c123322dff0ab779b Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
