Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: convert remaining widgets to PatternFly tooltips ......................................................................
Patch Set 17: (8 comments) https://gerrit.ovirt.org/#/c/38360/17/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java: Line 80: @UiField Line 81: SimplePanel contentWidgetContainer; Line 82: Line 83: @UiField Line 84: WidgetTooltip labelElementTooltip; Shouldn't this be just LabelTooltip? Line 85: Line 86: @UiField Line 87: WidgetTooltip contentWidgetContainerTooltip; Line 88: https://gerrit.ovirt.org/#/c/38360/17/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandButton.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandButton.java: Line 93: Line 94: /** Line 95: * Use prohibition reasons for tooltip Line 96: */ Line 97: protected String buildTooltipText() { Wouldn't this read much better? String tooltipText = null; if (!getCommand().getExecuteProhibitionReasons().isEmpty()) { tooltipText = ""; for (String reason: getCommand().getExecuteProhibitionReasons()) { if (!tooltipText.isEmpty()) { tooltipText += ", "; } tooltipText += reason; } } return tooltipText; Line 98: String tooltipText = null; Line 99: Line 100: StringBuilder sb = new StringBuilder(); Line 101: if (!getCommand().getExecuteProhibitionReasons().isEmpty()) { https://gerrit.ovirt.org/#/c/38360/17/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/DropdownActionButton.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/DropdownActionButton.java: Line 43: Line 44: private final static CommonApplicationResources resources = AssetProvider.getResources(); Line 45: Line 46: public DropdownActionButton(List<ActionButtonDefinition<T>> actions, List selectedItems) { Line 47: super(); implicit Line 48: initDropdownButton(); Line 49: initWidget(WidgetUiBinder.uiBinder.createAndBindUi(this)); Line 50: initMenuPopup(actions, selectedItems); Line 51: addMouseHandlers(); https://gerrit.ovirt.org/#/c/38360/17/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/SimpleActionButton.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/SimpleActionButton.java: Line 21: @UiField Line 22: Style style; Line 23: Line 24: public SimpleActionButton() { Line 25: super(); super() is implied Line 26: initWidget(WidgetUiBinder.uiBinder.createAndBindUi(this)); Line 27: Line 28: button.addClickHandler(new ClickHandler() { Line 29: @Override https://gerrit.ovirt.org/#/c/38360/17/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/BaseEntityModelDetachableWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/BaseEntityModelDetachableWidget.java: Line 17: Line 18: private final static CommonApplicationResources resources = AssetProvider.getResources(); Line 19: private final static CommonApplicationConstants constants = AssetProvider.getConstants(); Line 20: Line 21: @UiField(provided = true) Does this need to be provided? Line 22: WidgetTooltip tooltip; Line 23: Line 24: Image attachedSeparatedImage; Line 25: Line 32: private BaseStyle style; Line 33: Line 34: private UIObject decoratedWidget; Line 35: Line 36: public BaseEntityModelDetachableWidget() { If it is not provided then we don't need this constructor. Line 37: this.tooltip = new WidgetTooltip(); Line 38: } Line 39: Line 40: // can not be as a constructor because needs to be called after the widgets get bind properly in children https://gerrit.ovirt.org/#/c/38360/17/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java: Line 22: setQuotaUsagePerUser(quotaUsagePerUser); Line 23: } Line 24: Line 25: public QuotaProgressBar() { Line 26: super(); super is implied Line 27: tooltip = new WidgetTooltip(this); Line 28: } Line 29: Line 30: public void setQuotaUsagePerUser(QuotaUsagePerUser quotaUsagePerUser) { https://gerrit.ovirt.org/#/c/38360/17/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/MainTabBasicListItemActionButton.java File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/MainTabBasicListItemActionButton.java: Line 30: Panel stylableButtonHolder; Line 31: Line 32: public MainTabBasicListItemActionButton(String tooltipText, ImageResource enabledImage, ImageResource disabledImage, Line 33: String additionalStyle) { Line 34: super(); implicit Line 35: initWidget(WidgetUiBinder.uiBinder.createAndBindUi(this)); Line 36: setTooltipText(tooltipText); Line 37: setEnabledHtml(SafeHtmlUtils.fromTrustedString(AbstractImagePrototype.create(enabledImage).getHTML())); Line 38: setDisabledHtml(SafeHtmlUtils.fromTrustedString(AbstractImagePrototype.create(disabledImage).getHTML())); -- To view, visit https://gerrit.ovirt.org/38360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic247147c091f4fa6e6c09689c85b6901c74f11f3 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
