Allon Mureinik has uploaded a new change for review.
Change subject: core: RemoveSnapshotSingleDisk ConcreteCreateTask
......................................................................
core: RemoveSnapshotSingleDisk ConcreteCreateTask
Removed ConcreteCreateTask from RemoveSnapshotSingleDiskCommand,
and used the new getTaskType() mechanism introduced to CommandBase.
Change-Id: Ic9eb4f2b87832de1418297a543ee33570d044c93
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
2 files changed, 8 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/98/7798/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java
index d27a83c..86edcef 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java
@@ -3,13 +3,8 @@
import org.ovirt.engine.core.common.VdcObjectType;
import org.ovirt.engine.core.common.action.ImagesContainterParametersBase;
import org.ovirt.engine.core.common.action.VdcActionType;
-import org.ovirt.engine.core.common.asynctasks.AsyncTaskCreationInfo;
-import org.ovirt.engine.core.common.asynctasks.AsyncTaskParameters;
import org.ovirt.engine.core.common.asynctasks.AsyncTaskType;
-import org.ovirt.engine.core.common.businessentities.AsyncTaskResultEnum;
-import org.ovirt.engine.core.common.businessentities.AsyncTaskStatusEnum;
import org.ovirt.engine.core.common.businessentities.DiskImage;
-import org.ovirt.engine.core.common.businessentities.async_tasks;
import
org.ovirt.engine.core.common.vdscommands.MergeSnapshotsVDSCommandParameters;
import org.ovirt.engine.core.common.vdscommands.VDSCommandType;
import org.ovirt.engine.core.common.vdscommands.VDSReturnValue;
@@ -55,12 +50,8 @@
}
@Override
- protected SPMAsyncTask ConcreteCreateTask(AsyncTaskCreationInfo
asyncTaskCreationInfo, VdcActionType parentCommand) {
- AsyncTaskParameters p = new AsyncTaskParameters(asyncTaskCreationInfo,
new async_tasks(parentCommand,
- AsyncTaskResultEnum.success, AsyncTaskStatusEnum.running,
asyncTaskCreationInfo.getTaskID(),
- getParameters(), asyncTaskCreationInfo.getStepId(),
getCommandId()));
- p.setEntityId(getParameters().getEntityId());
- return
AsyncTaskManager.getInstance().CreateTask(AsyncTaskType.mergeSnapshots, p);
+ protected AsyncTaskType getTaskType() {
+ return AsyncTaskType.mergeSnapshots;
}
@Override
diff --git
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
index 2e9d9f5..e2c7244 100644
---
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
+++
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
@@ -92,6 +92,12 @@
// No op for test
}
+ },
+ new RemoveSnapshotSingleDiskCommand(new
ImagesContainterParametersBase()) {
+ @Override
+ protected void
initContainerDetails(ImagesContainterParametersBase parameters) {
+ // No op for test
+ }
}
};
}
--
To view, visit http://gerrit.ovirt.org/7798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9eb4f2b87832de1418297a543ee33570d044c93
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
