Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: convert all grid Headers to PatternFly tooltips ......................................................................
Patch Set 11: (5 comments) https://gerrit.ovirt.org/#/c/38175/11/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCellWithElementId.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCellWithElementId.java: Line 5: import com.google.gwt.cell.client.AbstractCell; Line 6: import com.google.gwt.user.client.DOM; Line 7: Line 8: /** Line 9: * TODO delete this -- AbstractTooltipCell already does this > This will be done in the next patch, right? yes Line 10: * A cell that sets an ID when it renders. Convenience implementation of CellWithElementId. Line 11: * Line 12: * @param <C> Line 13: * Cell data type. https://gerrit.ovirt.org/#/c/38175/11/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/AbstractHeader.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/AbstractHeader.java: Line 16: * @param <H> Cell data type. Line 17: */ Line 18: public abstract class AbstractHeader<H> extends Header<H> implements ColumnWithElementId, TooltipHeader { Line 19: Line 20: ValueUpdater<H> updater = null; > Can we make this field private? Done Line 21: Line 22: public AbstractHeader(Cell<H> cell) { Line 23: super(cell); Line 24: } https://gerrit.ovirt.org/#/c/38175/11/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizableHeader.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizableHeader.java: Line 120: public static SafeHtmlCell createSafeHtmlCell() { Line 121: return new SafeHtmlCell() { Line 122: @Override Line 123: public Set<String> getConsumedEvents() { Line 124: Set<String> set = new HashSet<String>(); > Could use HashSet(collection) constructor here: Done Line 125: set.add(BrowserEvents.CLICK); // for sorting Line 126: set.add(BrowserEvents.MOUSEMOVE); // for changing mouse cursor Line 127: set.addAll(super.getConsumedEvents()); Line 128: return set; https://gerrit.ovirt.org/#/c/38175/11/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizeableCheckboxHeader.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizeableCheckboxHeader.java: Line 28: public static SafeHtmlCell createSafeHtmlCell() { Line 29: return new SafeHtmlCell() { Line 30: @Override Line 31: public Set<String> getConsumedEvents() { Line 32: Set<String> set = new HashSet<String>(); > Same comment as in ResizableHeader.java Done Line 33: set.add(BrowserEvents.CLICK); // for sorting Line 34: set.add(BrowserEvents.MOUSEMOVE); // for changing mouse cursor Line 35: set.add(BrowserEvents.CHANGE); // for checkbox toggle Line 36: set.addAll(super.getConsumedEvents()); https://gerrit.ovirt.org/#/c/38175/11/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/SafeHtmlHeader.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/SafeHtmlHeader.java: Line 48: public static SafeHtmlCell createSafeHtmlCell() { Line 49: return new SafeHtmlCell() { Line 50: @Override Line 51: public Set<String> getConsumedEvents() { Line 52: Set<String> set = new HashSet<String>(); > Same comment as in ResizableHeader.java Done Line 53: set.add(BrowserEvents.CLICK); // for sorting Line 54: set.addAll(super.getConsumedEvents()); Line 55: return set; Line 56: } -- To view, visit https://gerrit.ovirt.org/38175 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33f5fbd37bdbdf7a60dee0b14bcd8dbc11ac5b24 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
