Daniel Erez has posted comments on this change. Change subject: core: catch OpenStackResponseException on execute ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/38926/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1186: processExceptionToClient(new VdcFault(e, e.getVdsError().getCode())); Line 1187: } catch (OpenStackResponseException e) { Line 1188: if (_returnValue.getExecuteFailedMessages().isEmpty()) { Line 1189: processExceptionToClient(new VdcFault(e, VdcBllErrors.ENGINE)); Line 1190: } > Why you don't want also to process exception to the client when the execute because in that case there's no need to add the fault to ExecuteFailedMessages list... Line 1191: log.error("Command '{}' failed: {}", getClass().getName(), e.getMessage()); Line 1192: log.error("Exception", e); Line 1193: } catch (RuntimeException e) { Line 1194: processExceptionToClient(new VdcFault(e, VdcBllErrors.ENGINE)); -- To view, visit https://gerrit.ovirt.org/38926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic84ee67e0cb83763d26bba82dd03131d5b97a38d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
