Alona Kaplan has posted comments on this change. Change subject: engine: Introduce HostNicVfsConfig business entity ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/35947/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNicVfsConfig.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNicVfsConfig.java: Line 14: Line 15: private Guid id; Line 16: Line 17: private Guid nicId; Line 18: > could you describe the nature of each *Vfs property to reduce confusion ? 1. Done. 2. HostNicVfsConfig isn't used a field of any VdcActionParameters class, so there is no need for annotations here. The fields of the parameters classes have annotations. Line 19: private int maxNumOfVfs; Line 20: Line 21: private int numOfVfs; Line 22: Line 24: Line 25: private boolean allNetworksAllowed; Line 26: Line 27: private List<Guid> networks; Line 28: > networkLabels will describe the nature of this field better Done Line 29: private List<String> labels; Line 30: Line 31: public Guid getNicId() { Line 32: return nicId; -- To view, visit https://gerrit.ovirt.org/35947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7124708e1fc2ba1ed1d827f9db54fe31a2e4856 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
