Martin Peřina has uploaded a new change for review.
Change subject: core: Fix unreachable code in FenceAgentDaoDbFacadeImpl
......................................................................
core: Fix unreachable code in FenceAgentDaoDbFacadeImpl
Fixes unreachable code in FenceAgentDaoDbFacadeImpl reported by
Coverity. Method ResultSet.getBoolean() return primitive type boolean so
there's no sense in casting it into object Boolean and check for null.
Change-Id: Ie8c1f2d53d2d5b65c67f51b969a9ccbc49fdb11e
Signed-off-by: Martin Perina <mper...@redhat.com>
---
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/FenceAgentDaoDbFacadeImpl.java
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/25/38925/1
diff --git
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/FenceAgentDaoDbFacadeImpl.java
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/FenceAgentDaoDbFacadeImpl.java
index 51a2dc3..772bd3f 100644
---
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/FenceAgentDaoDbFacadeImpl.java
+++
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/FenceAgentDaoDbFacadeImpl.java
@@ -112,8 +112,7 @@
entity.setPassword(DbFacadeUtils.decryptPassword(rs.getString("agent_password")));
int port = rs.getInt("port");
entity.setPort(port == 0 ? null : port);
- final Boolean encryptOptions = rs.getBoolean("encrypt_options");
- entity.setEncryptOptions(encryptOptions == null ? false :
encryptOptions);
+ entity.setEncryptOptions(rs.getBoolean("encrypt_options"));
final String options = rs.getString("options");
if (entity.getEncryptOptions() && !options.isEmpty()) {
entity.setOptions(DbFacadeUtils.decryptPassword(options));
--
To view, visit https://gerrit.ovirt.org/38925
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8c1f2d53d2d5b65c67f51b969a9ccbc49fdb11e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
