Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: introduce AssetProvider ......................................................................
Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/38724/7/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.java: Line 21: interface WidgetUiBinder extends UiBinder<Widget, EntityModelWidgetWithInfo> { Line 22: WidgetUiBinder uiBinder = GWT.create(WidgetUiBinder.class); Line 23: } Line 24: Line 25: private final static CommonApplicationResources resources = AssetProvider.getResources(); unused Line 26: Line 27: @UiField(provided = true) Line 28: EntityModelLabel<T> label; Line 29: https://gerrit.ovirt.org/#/c/38724/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CloneVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CloneVmModel.java: Line 32 Line 33 Line 34 Line 35 Line 36 I think this one should stay, its a different constants. https://gerrit.ovirt.org/#/c/38724/7/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/AbstractDynamicImage.java File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/AbstractDynamicImage.java: Line 23 Line 24 Line 25 Line 26 Line 27 Pretty sure this should stay. -- To view, visit https://gerrit.ovirt.org/38724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifafe5a16068452dac46208c6f06b05c113403443 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
