Alona Kaplan has posted comments on this change. Change subject: engine: make UpdateVdsGroupCommand be able to get mgmt network param ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/37732/4/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java: Line 260: canDoActionFailedWithReason(VdcBllMessages.ACTION_TYPE_FAILED_DEFAULT_MANAGEMENT_NETWORK_NOT_FOUND); Line 261: } Line 262: Line 263: @Test Line 264: public void detachedClusterMovesToDcWithNonExistentManagementNetwork() { Please add test for- detachedClusterMovesToDcWithExistingManagementNetwork Line 265: managementNetworkNotFoundById(); Line 266: Line 267: createCommandWithDefaultVdsGroup(); Line 268: oldGroupIsDetachedDefault(); -- To view, visit https://gerrit.ovirt.org/37732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I393fedd9e104acc84eb78ea239b4eb33f77ba802 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
