Sahina Bose has posted comments on this change. Change subject: engine: Peer probing with alternate addresses ......................................................................
Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/38149/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java: Line 210: !Objects.equals(server.getId(), removedServer.getId()) > When will this be true? The list being passed is the list retrieved before the server is removed. so we need to reset the address only for the one that's remaining. will update comment Line 218: glusterServer > This can be passed as an argument, caller knows this no, the caller knows GlusterServerInfo that's returned from vds not the one stored in database https://gerrit.ovirt.org/#/c/38149/9/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerDaoDbFacadeImpl.java: Line 53: knownAddresses.split(","); : ArrayList<String> knownAddressList = new ArrayList<>(); : for (String addr : knownAddressArray) { : knownAddressList.add(addr); : } > Arrays.asList(knownAddresses.split(",")) can be used here This returns a List type, but the method takes an ArrayList parameter - which is why I did this -- To view, visit https://gerrit.ovirt.org/38149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fa407d6a525e73b89a79d063517798283b520fd Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
