Alexander Wels has posted comments on this change. Change subject: webadmin: no auto logout when idle ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/37837/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 3578: return source; Line 3579: } Line 3580: }; Line 3581: IdQueryParameters queryParams = new IdQueryParameters(vmId); Line 3582: queryParams.setRefresh(false); > This could be shortened a bit, instead of: Done Line 3583: Frontend.getInstance().runQuery(VdcQueryType.GetVmGuestAgentInterfacesByVmId, queryParams, aQuery); Line 3584: } Line 3585: Line 3586: public void getVnicProfilesByNetworkId(AsyncQuery aQuery, Guid networkId) { https://gerrit.ovirt.org/#/c/37837/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractGeneralModel.java: Line 38: return; Line 39: } Line 40: Line 41: IdQueryParameters queryParams = new IdQueryParameters(entityId); Line 42: queryParams.setRefresh(false); > Same comment as in AsyncDataProvider.java Done Line 43: Frontend.getInstance().runQuery(VdcQueryType.GetGraphicsDevices, queryParams, new AsyncQuery( Line 44: this, Line 45: new INewAsyncCallback() { Line 46: @Override -- To view, visit https://gerrit.ovirt.org/37837 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52b9ea108ddca3d2d137860b9425691ffc0a95ef Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
