Eli Mesika has posted comments on this change.

Change subject: core: set cluster for host registration if null
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/37842/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java:

Line 52:      */
Line 53:     private static final BitSet validChars = new BitSet('z' + 1);
Line 54: 
Line 55:     @Inject
Line 56:     protected AuditLogDirector auditLogDirector;
> this field should be removed. it is already defined in QueriesCommandBase.
Done
Line 57: 
Line 58:     static {
Line 59:         // the set method sets the bits from the specified from 
index(inclusive) to the specified toIndex(exclusive) to
Line 60:         // true so the toIndex should be incremented in 1 in order to 
include the char represented by that index in the


-- 
To view, visit https://gerrit.ovirt.org/37842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5eda0fe04de8338a49000d62338717584518b153
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to