Ramesh N has posted comments on this change. Change subject: gluster: Add support for gluster brick creation ......................................................................
Patch Set 18: (7 comments) https://gerrit.ovirt.org/#/c/36031/18/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/CreateBrickModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/CreateBrickModel.java: Line 84: // brick Line 85: // capacity. Line 86: if (getStorageDevices().getSelectedItems() != null) { Line 87: for (StorageDevice storageDevice : getStorageDevices().getSelectedItems()) { Line 88: if (storageDevice.getCanCreateBrick()) { > Isn't this check is redundant? Yeap. Removed now. Line 89: totalSize += storageDevice.getSize(); Line 90: } Line 91: } Line 92: } https://gerrit.ovirt.org/#/c/36031/18/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java: Line 114: protected String getListName() { Line 115: return "HostGlusterStorageDevicesListModel"; //$NON-NLS-1$ Line 116: } Line 117: Line 118: private void showCreateBrickDialog() { > just call it as createBrick() Done Line 119: final List<StorageDevice> eligibleDevices = new ArrayList<StorageDevice>(); Line 120: if (getWindow() != null) { Line 121: return; Line 122: } Line 115: return "HostGlusterStorageDevicesListModel"; //$NON-NLS-1$ Line 116: } Line 117: Line 118: private void showCreateBrickDialog() { Line 119: final List<StorageDevice> eligibleDevices = new ArrayList<StorageDevice>(); > eligibleDevices this can be moved below to the onSuccess() method Done Line 120: if (getWindow() != null) { Line 121: return; Line 122: } Line 123: Line 191: getCreateBrickCommand().setIsExecutionAllowed(vds.getStatus() == VDSStatus.Up); Line 192: } Line 193: } Line 194: Line 195: private void createBrick() { > This could be 'onCreateBrick' Done Line 196: CreateBrickModel lvModel = (CreateBrickModel) getWindow(); Line 197: if (lvModel == null) { Line 198: return; Line 199: } Line 233: Line 234: private void postCreateBrick() { Line 235: CreateBrickModel model = (CreateBrickModel) getWindow(); Line 236: model.stopProgress(); Line 237: setWindow(null); > You should close the window only if the response is success Done Line 238: } Line 239: Line 240: @Override Line 241: public void executeCommand(UICommand command) { https://gerrit.ovirt.org/#/c/36031/18/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/CreateBrickPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/CreateBrickPopupView.java: Line 87: Line 88: @UiField Line 89: @Path(value = "noOfPhysicalDisksInRaidVolume.entity") Line 90: @WithElementId Line 91: IntegerEntityModelTextBoxEditor NoOfPhysicalDisksEditor; > noOfPhysicalDisksEditor Done Line 92: Line 93: @UiField Line 94: @Path(value = "stripeSize.entity") Line 95: @WithElementId https://gerrit.ovirt.org/#/c/36031/18/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/CreateBrickPopupView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/CreateBrickPopupView.ui.xml: Line 1: <?xml version="1.0" encoding="UTF-8"?> Line 2: <!DOCTYPE ui:UiBinder SYSTEM "http://dl.google.com/gwt/DTD/xhtml.ent";> Line 3: <ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder" > Remove unwanted imports removed. Line 4: xmlns:g="urn:import:com.google.gwt.user.client.ui" xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog" Line 5: xmlns:e="urn:import:org.ovirt.engine.ui.common.widget.editor" Line 6: xmlns:ge="urn:import:org.ovirt.engine.ui.common.widget.editor.generic" Line 7: xmlns:t="urn:import:org.ovirt.engine.ui.common.widget.dialog.tab" -- To view, visit https://gerrit.ovirt.org/36031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If43b6503dd8362d2a0907ac9648335a750828427 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
