Sandro Bonazzola has posted comments on this change. Change subject: hosted-engine: allow to deploy hosted-engine ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/38547/10/src/ovirt_host_deploy/constants.py File src/ovirt_host_deploy/constants.py: Line 79: CERTIFICATE_ENROLLMENT_INLINE = 'inline' Line 80: CERTIFICATE_ENROLLMENT_REQUEST = 'request' Line 81: CERTIFICATE_ENROLLMENT_ACCEPT = 'accept' Line 82: HA_AGENT_SERVICE = 'ovirt-ha-agent' Line 83: HA_BROCKER_SERVICE = 'ovirt-ha-broker' > these can go into your module, no need to have these here, especially not a Done Line 84: Line 85: Line 86: @util.export Line 87: @util.codegen -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
