Ramesh N has posted comments on this change. Change subject: engine: vds commands for gluster brick create ......................................................................
Patch Set 15: (3 comments) Patch set to follow https://gerrit.ovirt.org/#/c/36029/15/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1766: withParameter > I feel raidParams is optional argument. If so we should use withOptionalPar Done https://gerrit.ovirt.org/#/c/36029/15/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java: Line 379: array > you may want to call this as 'devices' changed it to storageDevices https://gerrit.ovirt.org/#/c/36029/15/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java: Line 1725: String mountPoint, Line 1726: Map<String, Object> raidParams, Line 1727: String[] storageDevices) { Line 1728: try { Line 1729: if (raidParams == null) { > As far as I remember vdsm code the default value is empty map so you could Will do that Line 1730: return new OneStorageDeviceReturnForXmlRpc(vdsServer.glusterCreateBrick(lvName, mountPoint, Line 1731: storageDevices)); Line 1732: } else { Line 1733: return new OneStorageDeviceReturnForXmlRpc(vdsServer.glusterCreateBrick(lvName, mountPoint, -- To view, visit https://gerrit.ovirt.org/36029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a74a9eeabd19b9780e4401d263e586261f488d Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
