Omer Frenkel has posted comments on this change. Change subject: core: VM Icons - backend part ......................................................................
Patch Set 4: (1 comment) partially reviewed (only db+dao part) please, in the future patches, split big patches like this to smaller one, here for example you could have one patch with db+dao+entities and another with commands+queries https://gerrit.ovirt.org/#/c/38600/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDao.java: Line 7: Line 8: /** Line 9: * Visual table viewer: http://jsfiddle.net/jniederm/u1bf0767/ Line 10: */ Line 11: public interface VmIconDao extends GenericDao<VmIcon, Guid> { please create dao test class for this dao also add appropriate entries in fixtures.xml Line 12: Line 13: public List<VmIcon> getByDataUrl(String dataUrl); Line 14: Line 15: /** -- To view, visit https://gerrit.ovirt.org/38600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98ad0d76285af3b2913e477a340bfd1ac09a296e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
