Allon Mureinik has posted comments on this change. Change subject: uicommonweb: Attach virtual IDE disks new behavior ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38663/1/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 2412: Line 2413: @DefaultStringValue("When the VM is running, cannot activate a disk attached with IDE interface.") Line 2414: String cannotHotPlugDiskWithIdeInterface(); Line 2415: Line 2416: @DefaultStringValue("Selected IDE disk/s will be attached but will need to be activated manually after the VM is shut down.") > Eldan thinks that since your suggestion lacks the part that tells the user "The selected IDE disk(s) will be attached, but will not be activated. In order to activate them, you should shut the VM down and manually activate them." Line 2417: String ideDisksWillBeAttachedButNotActivated(); Line 2418: Line 2419: @DefaultStringValue("Cannot activate disk, VM should be in Down, Paused or Up status.") Line 2420: String cannotPlugDiskIncorrectVmStatus(); -- To view, visit https://gerrit.ovirt.org/38663 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I187c74c7c39f438dfa5e81942f4a6aec41323830 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Candace Sheremeta <csher...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
