Alexander Wels has posted comments on this change. Change subject: webadmin : gwt-bootstrap DateTimeBox widget ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38729/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GwtBootstrapDateTimePicker.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GwtBootstrapDateTimePicker.java: Line 27: */ Line 28: public static final String DEFAULT_DATE_TIME_FORMAT = "mm/dd/yyyy HH:ii";//$NON-NLS-1$ Line 29: public static final String DEFAULT_TIME_FORMAT = "HH:ii";//$NON-NLS-1$ Line 30: public static final String DEFAULT_DATE_FORMAT = "mm/dd/yyyy";//$NON-NLS-1$ Line 31: private final DateTimePicker dateTimePicker = new DateTimePicker(); > So, basically the supposed base class DateTimePicker somewhere down the lin I think Gregs point is that all this class does is implement TakesValue<Date> and we should be able to extend DateTimePicker and also implement TakesValue at the same time. Not sure if this will actually reduce the amount of code or not. Line 32: private String dateTimeFormat; Line 33: Line 34: public GwtBootstrapDateTimePicker() { Line 35: this(DEFAULT_DATE_TIME_FORMAT, true); -- To view, visit https://gerrit.ovirt.org/38729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92f2a9eced817d8ed040901255983e5673990f1f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
