[Engine-patches] Change in ovirt-engine[master]: backend: adding @Mask annotation

[masayag]

Moti Asayag has posted comments on this change.

Change subject: backend: adding @Mask annotation
......................................................................


Patch Set 20: Code-Review+1

(2 comments)

Minor style comments.

https://gerrit.ovirt.org/#/c/35155/20/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/ValidatorConstraint.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/ValidatorConstraint.java:

Line 16:     public boolean isValid(ValidatorConstraintArgsFormatValue args, 
ConstraintValidatorContext context, String nodeName) {
Line 17:         if (!args.isValidFormat()) {
Line 18:             return failWith(context, args.getBadFormatErrorMessage(), 
nodeName);
Line 19:         }
Line 20:         else if (!args.isValidValue()) {
please merge the lines

  if () {
  ..
  } else {
  ...
  }
Line 21:             return failWith(context, args.getBadValueErrorMessage(), 
nodeName);
Line 22:         }
Line 23: 
Line 24:         return true;


Line 53:         public String getBadValueErrorMessage() {
Line 54:             return badValueErrorMessage;
Line 55:         }
Line 56: 
Line 57:         public ValidatorConstraintArgsFormatValue(boolean 
isValidFormat,
please declare c'tor before any other class methods.
Line 58:                 boolean isValidValue,
Line 59:                 String badFormatErrorMessage,
Line 60:                 String badValueErrorMessage) {
Line 61:             this.validFormat = isValidFormat;


-- 
To view, visit https://gerrit.ovirt.org/35155
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If92f2ec51f9cb647d6008b2fd2b1ab4c3db1d3f1
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <el...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Eliraz Levi <el...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches