Tal Nisan has posted comments on this change.

Change subject: core: Moved storage related entities to the storage package
......................................................................


Patch Set 4:

(4 comments)

https://gerrit.ovirt.org/#/c/38650/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java:

Line 9: import 
org.ovirt.engine.core.common.action.StorageServerConnectionParametersBase;
Line 10: import org.ovirt.engine.core.common.action.VdcActionType;
Line 11: import org.ovirt.engine.core.common.action.VdcReturnValueBase;
Line 12: import org.ovirt.engine.core.common.businessentities.StorageDomain;
Line 13: import 
org.ovirt.engine.core.common.businessentities.StorageDomainStatic;
> Isn't those are also supposed to be grouped under storage? (StorageDomain, 
Probably, but not in this scope, I'm trying to focus now on entities that are 
related to disks & images directly.
It will be moved later on in a separate patch, I've got enough conflicts as it 
is.
Line 14: import 
org.ovirt.engine.core.common.businessentities.StorageServerConnections;
Line 15: import 
org.ovirt.engine.core.common.businessentities.storage.StorageType;
Line 16: import org.ovirt.engine.core.common.errors.VdcFault;
Line 17: import org.ovirt.engine.core.common.utils.Pair;


https://gerrit.ovirt.org/#/c/38650/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java:

Line 4: import java.util.List;
Line 5: import java.util.Map;
Line 6: import java.util.TreeMap;
Line 7: 
Line 8: import org.ovirt.engine.core.common.businessentities.StorageFormatType;
> Shouldn't StorageFormatType also have been moved?
Probably, but not in this scope, I'm trying to focus now on entities that are 
related to disks & images directly.
It will be moved later on in a separate patch, I've got enough conflicts as it 
is.
Line 9: import 
org.ovirt.engine.core.common.businessentities.storage.StorageType;
Line 10: import org.ovirt.engine.core.compat.Version;
Line 11: 
Line 12: /**


https://gerrit.ovirt.org/#/c/38650/4/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/StorageTypeTest.java
File 
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/StorageTypeTest.java:

Line 1: package org.ovirt.engine.core.common.businessentities;
> This class should also be moved to the storage package, alongside the class
I'll move all storage tests later on
Line 2: 
Line 3: import org.junit.Test;
Line 4: 
Line 5: import org.junit.Assert;


https://gerrit.ovirt.org/#/c/38650/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java:

Line 1: package org.ovirt.engine.ui.common.widget.uicommon.storage;
Line 2: 
Line 3: import org.ovirt.engine.core.common.businessentities.storage.DiskImage;
> Should be sorted to the right place
Done
Line 4: import org.ovirt.engine.core.common.businessentities.Quota;
Line 5: import org.ovirt.engine.core.common.businessentities.StorageDomain;
Line 6: import org.ovirt.engine.core.common.businessentities.storage.VolumeType;
Line 7: import 
org.ovirt.engine.core.common.businessentities.profiles.DiskProfile;


-- 
To view, visit https://gerrit.ovirt.org/38650
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54f304e2453ea0acd773a891e651190a3093eccc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Fred Rolland <froll...@redhat.com>
Gerrit-Reviewer: Idan Shaby <ish...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to