Moti Asayag has posted comments on this change. Change subject: common: adding maskValidator util ......................................................................
Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/35144/14/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IpAddressConverterTest.java File backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IpAddressConverterTest.java: Line 14: Line 15: final private String ipAddress; Line 16: final private long ipAsLong; Line 17: Line 18: public IpAddressConverterTest(String ipAdd, long ipAsLong) { :-) ipAdd should also be renamed to ipAddress. Assume someone is going to generate javadoc, without any description out of this c'tor. ipAdd could be understood as some strange ip arithmetic value. Hence both the local variable name and the parameter name should be changed accordingly. Line 19: this.ipAddress = ipAdd; Line 20: this.ipAsLong = ipAsLong; Line 21: } Line 22: -- To view, visit https://gerrit.ovirt.org/35144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04fb0aa2193801688f1bfc5dc7684cabdfa2827d Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eliraz Levi <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
