Greg Sheremeta has uploaded a new change for review.
Change subject: webadmin: remove 'keepTitleOnSetEnabled' property
......................................................................
webadmin: remove 'keepTitleOnSetEnabled' property
(Patch 4ap of 12)
Removed 'keepTitleOnSetEnabled' property from AbstractValidatedWidgetWithLabel.
New tooltips are always enabled on AbstractValidatedWidgetWithLabel.
Change-Id: Iea8e449bc720ff32c9936bf78cd0e4e54bce50a6
Signed-off-by: Greg Sheremeta <gsher...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
2 files changed, 1 insertion(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/39/38739/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java
index 37778b2..2ec63cb 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java
@@ -83,13 +83,6 @@
// width in PX -- only used in legacy mode
public static final int CONTENT_WIDTH_LEGACY = 230;
- /**
- * By default the title gets erased, when the setEnabled is called
- * <p>
- * This switch disables it
- */
- private boolean keepTitleOnSetEnabled = false;
-
private VisibilityRenderer renderer;
public AbstractValidatedWidgetWithLabel(W contentWidget,
VisibilityRenderer renderer) {
@@ -275,15 +268,12 @@
} else {
getFormLabel().getElement().replaceClassName(OvirtCss.LABEL_ENABLED,
OvirtCss.LABEL_DISABLED);
}
-
- if (!keepTitleOnSetEnabled) {
- updateWidgetTitle(null);
- }
}
@Override
public void disable(String disabilityHint) {
setEnabled(false);
+ // TODO save the normal tooltip (done in follow-up patch)
updateWidgetTitle(disabilityHint);
}
@@ -361,10 +351,6 @@
public void hideLabel() {
getFormLabel().setVisible(false);
- }
-
- public void setKeepTitleOnSetEnabled(boolean keepTitleOnSetEnabled) {
- this.keepTitleOnSetEnabled = keepTitleOnSetEnabled;
}
public VisibilityRenderer getRenderer() {
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
index 92a0c51..6962963 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
@@ -967,7 +967,6 @@
expander.initWithContent(expanderContent.getElement());
vcpusAdvancedParameterExpander.initWithContent(vcpusAdvancedParameterExpanderContent.getElement());
- editPrestartedVmsEditor.setKeepTitleOnSetEnabled(true);
applyStyles();
@@ -1066,9 +1065,6 @@
protected void initPoolSpecificWidgets(CommonApplicationResources
resources,
final CommonApplicationMessages messages) {
createNumOfDesktopEditors();
-
- incraseNumOfVmsEditor.setKeepTitleOnSetEnabled(true);
- numOfVmsEditor.setKeepTitleOnSetEnabled(true);
newPoolPrestartedVmsIcon =
new
InfoIcon(applicationTemplates.italicText(messages.prestartedHelp()), resources);
--
To view, visit https://gerrit.ovirt.org/38739
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea8e449bc720ff32c9936bf78cd0e4e54bce50a6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
