Moti Asayag has posted comments on this change. Change subject: core: DI for AuditLoggerDirector ......................................................................
Patch Set 7: (2 comments) minor comments only - good work! https://gerrit.ovirt.org/#/c/33901/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java: Line 115: log.info("Power-Management: {} host '{}' failed.", getAction(), getVdsName()); Line 116: audit(AuditLogType.FENCE_OPERATION_FAILED); Line 117: } Line 118: } catch(Exception e) { Line 119: e.printStackTrace(System.err); why is it here ? Line 120: } finally { Line 121: if (!getSucceeded()) { Line 122: setStatus(lastStatus); Line 123: if (!wasSkippedDueToPolicy(result)) { https://gerrit.ovirt.org/#/c/33901/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsFromExternalProviderQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsFromExternalProviderQuery.java: Line 17: Line 18: public class GetVmsFromExternalProviderQuery<T extends GetVmsFromExternalProviderQueryParameters> extends QueriesCommandBase<T> { Line 19: Line 20: @Inject Line 21: private AuditLogDirector auditLogDirector; is it required if already added to QueriesCommandBase ? Line 22: Line 23: public GetVmsFromExternalProviderQuery(T parameters) { Line 24: this(parameters, null); Line 25: } -- To view, visit https://gerrit.ovirt.org/33901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifab56339a634234bbc51fa09719fb87b5cc69501 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
