Greg Sheremeta has uploaded a new change for review.
Change subject: webadmin: refactor - rename VmButtonsImageButtonCell ->
AbstractVmButtonsImageButtonCell
......................................................................
webadmin: refactor - rename VmButtonsImageButtonCell ->
AbstractVmButtonsImageButtonCell
(Patch 4ad of 12)
Renamed VmButtonsImageButtonCell -> AbstractVmButtonsImageButtonCell since it's
abstract.
Also marked the inner class as protected.
No functional changes -- just a refactor.
Change-Id: Ia8a3fcc38060585802a10dca8c2174ea40b0a208
Signed-off-by: Greg Sheremeta <gsher...@redhat.com>
---
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/38726/1
diff --git
a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java
b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java
index f44b4ab..7c456dd 100644
---
a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java
+++
b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java
@@ -303,7 +303,7 @@
}
protected CompositeCell<UserPortalItemModel>
createActionsCompositeCell(String elementIdPrefix) {
- ImageButtonCell<UserPortalItemModel> runCell = new
VmButtonsImageButtonCell(
+ ImageButtonCell<UserPortalItemModel> runCell = new
AbstractVmButtonsImageButtonCell(
applicationResources.playIcon(),
applicationResources.playDisabledIcon()) {
@Override
protected String getTitle(UserPortalItemModel value) {
@@ -318,7 +318,7 @@
runCell.setElementIdPrefix(elementIdPrefix);
runCell.setColumnId("runButton"); //$NON-NLS-1$
- ImageButtonCell<UserPortalItemModel> shutdownCell = new
VmButtonsImageButtonCell(
+ ImageButtonCell<UserPortalItemModel> shutdownCell = new
AbstractVmButtonsImageButtonCell(
applicationResources.stopIcon(),
applicationResources.stopDisabledIcon()) {
@Override
protected String getTitle(UserPortalItemModel value) {
@@ -333,7 +333,7 @@
shutdownCell.setElementIdPrefix(elementIdPrefix);
shutdownCell.setColumnId("shutdownButton"); //$NON-NLS-1$
- ImageButtonCell<UserPortalItemModel> suspendCell = new
VmButtonsImageButtonCell(
+ ImageButtonCell<UserPortalItemModel> suspendCell = new
AbstractVmButtonsImageButtonCell(
applicationResources.suspendIcon(),
applicationResources.suspendDisabledIcon()) {
@Override
protected String getTitle(UserPortalItemModel value) {
@@ -348,7 +348,7 @@
suspendCell.setElementIdPrefix(elementIdPrefix);
suspendCell.setColumnId("suspendButton"); //$NON-NLS-1$
- ImageButtonCell<UserPortalItemModel> stopCell = new
VmButtonsImageButtonCell(
+ ImageButtonCell<UserPortalItemModel> stopCell = new
AbstractVmButtonsImageButtonCell(
applicationResources.powerIcon(),
applicationResources.powerDisabledIcon()) {
@Override
protected String getTitle(UserPortalItemModel value) {
@@ -363,7 +363,7 @@
stopCell.setElementIdPrefix(elementIdPrefix);
stopCell.setColumnId("stopButton"); //$NON-NLS-1$
- ImageButtonCell<UserPortalItemModel> rebootCell = new
VmButtonsImageButtonCell(
+ ImageButtonCell<UserPortalItemModel> rebootCell = new
AbstractVmButtonsImageButtonCell(
applicationResources.rebootIcon(),
applicationResources.rebootDisabledIcon()) {
@Override
@@ -399,9 +399,9 @@
TableStyle cellTableStyle();
}
- abstract class VmButtonsImageButtonCell extends
ImageButtonCell<UserPortalItemModel> {
+ protected abstract class AbstractVmButtonsImageButtonCell extends
ImageButtonCell<UserPortalItemModel> {
- public VmButtonsImageButtonCell(ImageResource enabledImage,
ImageResource disabledImage) {
+ public AbstractVmButtonsImageButtonCell(ImageResource enabledImage,
ImageResource disabledImage) {
super(enabledImage,
applicationResources.sideTabExtendedVmStyle().vmButtonEnabled(),
disabledImage,
applicationResources.sideTabExtendedVmStyle().vmButtonDisabled());
}
--
To view, visit https://gerrit.ovirt.org/38726
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8a3fcc38060585802a10dca8c2174ea40b0a208
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
