Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: Sortable Column refactor ......................................................................
Patch Set 2: (4 comments) Nice refactor patch! https://gerrit.ovirt.org/#/c/38702/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractColumn.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractColumn.java: Line 41: * @param sortBy Line 42: * Name of the field to sort by, used within the search query. Line 43: */ Line 44: @Override Line 45: public void makeSortable(String sortBy) { I think you can remove the Javadoc here, because this method is an implementation of an interface method that already has a Javadoc (which is inherited automatically). Line 46: assert sortBy != null : "sortBy cannot be null"; //$NON-NLS-1$ Line 47: this.sortBy = sortBy; Line 48: this.comparator = null; Line 49: setSortable(true); Line 55: * @param comparator Line 56: * Comparator for sorting table row data objects. Line 57: */ Line 58: @Override Line 59: public void makeSortable(Comparator<? super T> comparator) { Same comment as above. Line 60: assert comparator != null : "comparator cannot be null"; //$NON-NLS-1$ Line 61: this.sortBy = null; Line 62: this.comparator = comparator; Line 63: setSortable(true); Line 68: * <p> Line 69: * Use this method if server-side sorting is supported by the underlying model. Line 70: */ Line 71: @Override Line 72: public String getSortBy() { Same comment as above. Line 73: return sortBy; Line 74: } Line 75: Line 76: /** Line 78: * <p> Line 79: * Use this method if server-side sorting is <em>not</em> supported by the underlying model. Line 80: */ Line 81: @Override Line 82: public Comparator<? super T> getComparator() { Same comment as above. Line 83: return comparator; Line 84: } Line 85: -- To view, visit https://gerrit.ovirt.org/38702 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d26f817b3e79e996590873fef782fac14967fd1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
