Vojtech Szocs has posted comments on this change. Change subject: webadmin: display contents of comments instead of icon ......................................................................
Patch Set 7: Code-Review+2 (1 comment) Looks good, please rebase to re-trigger the CI job to ensure the build passes. https://gerrit.ovirt.org/#/c/38176/7/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java: Line 50: Line 51: int maxSpmPriority; Line 52: int defaultSpmPriority; Line 53: ApplicationConstants constants; Line 54: ApplicationResources resources; These should be private and final if possible, but it's out of scope for this patch I guess. Line 55: Line 56: @Inject Line 57: public MainTabHostView(MainModelProvider<VDS, HostListModel> modelProvider, ApplicationConstants constants, Line 58: ApplicationResources resources) { -- To view, visit https://gerrit.ovirt.org/38176 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3fc02811992fefe1723e9cd273e057e3639e310 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
