Vojtech Szocs has posted comments on this change. Change subject: webadmin: Host General sub tab ......................................................................
Patch Set 4: Code-Review+2 (1 comment) Looks good! BTW what happens when we change URL to #host-general ? (Revealing Host sub tab *panel* itself doesn't make much sense, in this scenario some of its "sub sub" tabs should be revealed.) https://gerrit.ovirt.org/#/c/37387/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/HostGeneralSubTabPanelPresenter.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/HostGeneralSubTabPanelPresenter.java: Line 37: HostGeneralSubTabPanelPresenter.ViewDef, HostGeneralSubTabPanelPresenter.ProxyDef> { Line 38: Line 39: @ProxyCodeSplit Line 40: @NameToken(WebAdminApplicationPlaces.hostGeneralSubTabPlace) Line 41: public interface ProxyDef extends TabContentProxyPlace<HostGeneralSubTabPanelPresenter> { OK so if I get this correctly, Host General sub tab now has its own tab panel (HostGeneralSubTabPanel*) under which specific "sub sub" tabs are revealed. (Usually, sub tab *panel* presenters don't have a place associated, but in this case, I guess it makes sense due to legacy reasons - we had #host-general sub tab place up to now.) Line 42: } Line 43: Line 44: public interface ViewDef extends AbstractSubTabPanelPresenter.ViewDef, DynamicTabPanel { Line 45: } -- To view, visit https://gerrit.ovirt.org/37387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie70cee7d4c5742a51ba6084968cf8617d0e2680e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
