Alexander Wels has posted comments on this change. Change subject: webadmin : CheckBoxGroup, DaysOfMonthSelector and DateTimeBox Widgets ......................................................................
Patch Set 13: (2 comments) https://gerrit.ovirt.org/#/c/37302/13/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GwtBootstrapDateTimePicker.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GwtBootstrapDateTimePicker.java: Line 42: }); Line 43: } Line 44: Line 45: public String getDateTimeFormat() { Line 46: return dateTimeFormat; return dateTimePicker.getFormat();? Line 47: } Line 48: Line 49: public void setDateTimeFormat(String dateTimeFormat) { Line 50: this.dateTimeFormat = dateTimeFormat; Line 45: public String getDateTimeFormat() { Line 46: return dateTimeFormat; Line 47: } Line 48: Line 49: public void setDateTimeFormat(String dateTimeFormat) { can't you just call dateTimePicker.setFormat(dateTimeFormat) here? That way you don't have to store the intermediate value. Line 50: this.dateTimeFormat = dateTimeFormat; Line 51: } Line 52: Line 53: public HandlerRegistration addValueChangeHandler(ValueChangeHandler<Date> handler) { -- To view, visit https://gerrit.ovirt.org/37302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38daa0d2c151eb0e34603488496a8a1ea4719c87 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
