Ramesh N has posted comments on this change. Change subject: gluster: vdc query for gettting un used bricks ......................................................................
Patch Set 10: (3 comments) Please review the patch set 11 https://gerrit.ovirt.org/#/c/36039/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetUnusedBricksQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetUnusedBricksQuery.java: Line 24: getQueryReturnValue().setReturnValue(getUnsedBricks(storageDevicesInHost)); Line 25: Line 26: } Line 27: Line 28: private List<StorageDevice> getUnsedBricks(List<StorageDevice> bricksFromServer) { > getUnusedBricks? Done Line 29: List<GlusterBrickEntity> usedBricks = Line 30: DbFacade.getInstance() Line 31: .getGlusterBrickDao() Line 32: .getGlusterVolumeBricksByServerId(getParameters().getVdsId()); Line 26: } Line 27: Line 28: private List<StorageDevice> getUnsedBricks(List<StorageDevice> bricksFromServer) { Line 29: List<GlusterBrickEntity> usedBricks = Line 30: DbFacade.getInstance() > getDbFacade() Done Line 31: .getGlusterBrickDao() Line 32: .getGlusterVolumeBricksByServerId(getParameters().getVdsId()); Line 33: List<StorageDevice> freeBricks = new ArrayList<StorageDevice>(); Line 34: Set<String> bricksDir = new HashSet<String>(); Line 36: bricksDir.add(brick.getBrickDirectory()); Line 37: } Line 38: for (StorageDevice brick : bricksFromServer) { Line 39: if (brick.getMountPoint() != null && !brick.getMountPoint().isEmpty() Line 40: && brick.getMountPoint().startsWith("/bricks/") && !bricksDir.contains(brick.getMountPoint())) { > mountPoint starts with "/bricks" or the default configured mount point? Done Line 41: freeBricks.add(brick); Line 42: } Line 43: } Line 44: -- To view, visit https://gerrit.ovirt.org/36039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida1563018939aa7e8160045c8e320ddab083c1fc Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
