Yevgeny Zaspitsky has posted comments on this change.

Change subject: webadmin: Add managemenet network field to new/edit cluster 
dialog
......................................................................


Patch Set 34:

(1 comment)

https://gerrit.ovirt.org/#/c/37141/34/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java:

Line 740:             actionType = VdcActionType.UpdateVdsGroup;
Line 741:             if (model.isClusterDetached()) {
Line 742:                 clusterOperationParameters = new 
ManagementNetworkOnClusterOperationParameters(cluster, managementNetworkId);
Line 743:             } else {
Line 744:                 clusterOperationParameters = new 
ManagementNetworkOnClusterOperationParameters(cluster);
> We're getting carried away to irrelevant discussions. I'm not going to give
Done.

Whatever you wish, Sir Maintainer.

But be ready for the coming bug...
Line 745:             }
Line 746:         }
Line 747:         Frontend.getInstance().runAction(
Line 748:                 actionType,


-- 
To view, visit https://gerrit.ovirt.org/37141
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I055babd6037f127235c349499f1545396e38333f
Gerrit-PatchSet: 34
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to