Omer Frenkel has posted comments on this change. Change subject: core, userportal, webadmin: VirtIO console access key management ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/35810/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetSshPublicKeyCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetSshPublicKeyCommand.java: Line 13: Line 14: import java.util.Collections; Line 15: import java.util.List; Line 16: Line 17: public class SetSshPublicKeyCommand <T extends SetSshPublicKeyParameters> extends CommandBase<T> { if we treat ssh key for user as "UserProfile" then this should be SetUserProfileCommand that get a UserProfile object from the client, contains all the info, no? this way we can allow admins to set ssh keys for other users if we like Line 18: Line 19: static final private String SSH_RSA = "ssh-rsa"; Line 20: Line 21: public SetSshPublicKeyCommand(T parameters) { -- To view, visit https://gerrit.ovirt.org/35810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2364cafc687ba6dee2504322234067ff98dc00c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
