Omer Frenkel has posted comments on this change. Change subject: engine: Do not change CD to the same ISO ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38357/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java: Line 61: } Line 62: Line 63: @Override Line 64: protected boolean shouldSkipCommandExecution() { Line 65: return StringUtils.equals(getVm().getCurrentCd(), getParameters().getCdImagePath()); need to check that getVm() is not null and also use it in canDoAction and also new audit log for the user to know it was skipped. please see usage example in StopVmCommandBase and ShutdownVmCommand Line 66: } Line 67: Line 68: @Override Line 69: protected void perform() { -- To view, visit https://gerrit.ovirt.org/38357 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf8df58b59f97612eab99ea81154e8034a39689 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
