Allon Mureinik has posted comments on this change. Change subject: core: Move BaseDisk entity to the storage package ......................................................................
Patch Set 1: Code-Review-1 (14 comments) https://gerrit.ovirt.org/#/c/38650/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java: Line 18: import org.ovirt.engine.core.bll.storage.StorageHelperDirector; Line 19: import org.ovirt.engine.core.bll.utils.ClusterUtils; Line 20: import org.ovirt.engine.core.bll.utils.VmDeviceUtils; Line 21: import org.ovirt.engine.core.bll.validator.storage.StorageDomainValidator; Line 22: import org.ovirt.engine.core.common.businessentities.storage.BaseDisk; Please sort the imports. Line 23: import org.ovirt.engine.core.common.businessentities.Disk; Line 24: import org.ovirt.engine.core.common.businessentities.Disk.DiskStorageType; Line 25: import org.ovirt.engine.core.common.businessentities.DiskImage; Line 26: import org.ovirt.engine.core.common.businessentities.DiskImageBase; https://gerrit.ovirt.org/#/c/38650/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java: Line 5: import org.ovirt.engine.core.bll.network.VmInterfaceManager; Line 6: import org.ovirt.engine.core.bll.smartcard.SmartcardSpecParams; Line 7: import org.ovirt.engine.core.bll.validator.VirtIoRngValidator; Line 8: import org.ovirt.engine.core.common.action.VmManagementParametersBase; Line 9: import org.ovirt.engine.core.common.businessentities.storage.BaseDisk; Please sort the imports. Line 10: import org.ovirt.engine.core.common.businessentities.Disk; Line 11: import org.ovirt.engine.core.common.businessentities.DiskImage; Line 12: import org.ovirt.engine.core.common.businessentities.DisplayType; Line 13: import org.ovirt.engine.core.common.businessentities.EditableDeviceOnVmStatusField; https://gerrit.ovirt.org/#/c/38650/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java: Line 13: import org.ovirt.engine.core.bll.ValidationResult; Line 14: import org.ovirt.engine.core.bll.validator.storage.DiskImagesValidator; Line 15: import org.ovirt.engine.core.common.VdcActionUtils; Line 16: import org.ovirt.engine.core.common.action.VdcActionType; Line 17: import org.ovirt.engine.core.common.businessentities.storage.BaseDisk; Please sort the imports. Line 18: import org.ovirt.engine.core.common.businessentities.Disk; Line 19: import org.ovirt.engine.core.common.businessentities.DiskImage; Line 20: import org.ovirt.engine.core.common.businessentities.DiskInterface; Line 21: import org.ovirt.engine.core.common.businessentities.Snapshot.SnapshotType; https://gerrit.ovirt.org/#/c/38650/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java: Line 6: import javax.validation.constraints.Size; Line 7: Line 8: import org.ovirt.engine.core.common.businessentities.BusinessEntitiesDefinitions; Line 9: import org.ovirt.engine.core.common.businessentities.BusinessEntity; Line 10: import org.ovirt.engine.core.common.businessentities.DiskAlignment; Should be moved to storage too. Line 11: import org.ovirt.engine.core.common.businessentities.DiskInterface; Line 12: import org.ovirt.engine.core.common.businessentities.IVdcQueryable; Line 13: import org.ovirt.engine.core.common.businessentities.PropagateErrors; Line 14: import org.ovirt.engine.core.common.businessentities.ScsiGenericIO; Line 7: Line 8: import org.ovirt.engine.core.common.businessentities.BusinessEntitiesDefinitions; Line 9: import org.ovirt.engine.core.common.businessentities.BusinessEntity; Line 10: import org.ovirt.engine.core.common.businessentities.DiskAlignment; Line 11: import org.ovirt.engine.core.common.businessentities.DiskInterface; Should be moved to storage too. Line 12: import org.ovirt.engine.core.common.businessentities.IVdcQueryable; Line 13: import org.ovirt.engine.core.common.businessentities.PropagateErrors; Line 14: import org.ovirt.engine.core.common.businessentities.ScsiGenericIO; Line 15: import org.ovirt.engine.core.common.utils.ObjectUtils; Line 9: import org.ovirt.engine.core.common.businessentities.BusinessEntity; Line 10: import org.ovirt.engine.core.common.businessentities.DiskAlignment; Line 11: import org.ovirt.engine.core.common.businessentities.DiskInterface; Line 12: import org.ovirt.engine.core.common.businessentities.IVdcQueryable; Line 13: import org.ovirt.engine.core.common.businessentities.PropagateErrors; Should be moved to storage too. Line 14: import org.ovirt.engine.core.common.businessentities.ScsiGenericIO; Line 15: import org.ovirt.engine.core.common.utils.ObjectUtils; Line 16: import org.ovirt.engine.core.common.validation.annotation.ValidDescription; Line 17: import org.ovirt.engine.core.common.validation.annotation.ValidI18NName; Line 10: import org.ovirt.engine.core.common.businessentities.DiskAlignment; Line 11: import org.ovirt.engine.core.common.businessentities.DiskInterface; Line 12: import org.ovirt.engine.core.common.businessentities.IVdcQueryable; Line 13: import org.ovirt.engine.core.common.businessentities.PropagateErrors; Line 14: import org.ovirt.engine.core.common.businessentities.ScsiGenericIO; Should be moved to storage too. Line 15: import org.ovirt.engine.core.common.utils.ObjectUtils; Line 16: import org.ovirt.engine.core.common.validation.annotation.ValidDescription; Line 17: import org.ovirt.engine.core.common.validation.annotation.ValidI18NName; Line 18: import org.ovirt.engine.core.common.validation.group.CreateEntity; https://gerrit.ovirt.org/#/c/38650/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java: Line 7: import java.util.LinkedList; Line 8: import java.util.List; Line 9: import java.util.Map; Line 10: Line 11: import org.ovirt.engine.core.common.businessentities.storage.BaseDisk; Please sort the imports. Line 12: import org.ovirt.engine.core.common.businessentities.BootSequence; Line 13: import org.ovirt.engine.core.common.businessentities.Disk; Line 14: import org.ovirt.engine.core.common.businessentities.VM; Line 15: import org.ovirt.engine.core.common.businessentities.VmDevice; https://gerrit.ovirt.org/#/c/38650/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java: Line 13: Line 14: import org.apache.commons.lang.StringUtils; Line 15: import org.ovirt.engine.core.common.ExternalVariable; Line 16: import org.ovirt.engine.core.common.VdcObjectType; Line 17: import org.ovirt.engine.core.common.businessentities.storage.BaseDisk; Please sort the imports. Line 18: import org.ovirt.engine.core.common.businessentities.BusinessEntity; Line 19: import org.ovirt.engine.core.common.businessentities.CommandEntity; Line 20: import org.ovirt.engine.core.common.businessentities.CpuStatistics; Line 21: import org.ovirt.engine.core.common.businessentities.DiskImage; https://gerrit.ovirt.org/#/c/38650/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractBaseDiskRowMapper.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractBaseDiskRowMapper.java: Line 3: import java.sql.ResultSet; Line 4: import java.sql.SQLException; Line 5: Line 6: import org.apache.commons.lang.StringUtils; Line 7: import org.ovirt.engine.core.common.businessentities.storage.BaseDisk; Please sort the imports. Line 8: import org.ovirt.engine.core.common.businessentities.DiskAlignment; Line 9: import org.ovirt.engine.core.common.businessentities.DiskInterface; Line 10: import org.ovirt.engine.core.common.businessentities.PropagateErrors; Line 11: import org.ovirt.engine.core.common.businessentities.ScsiGenericIO; https://gerrit.ovirt.org/#/c/38650/1/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java: Line 3: import static org.junit.Assert.assertFalse; Line 4: import static org.junit.Assert.assertTrue; Line 5: Line 6: import org.junit.Test; Line 7: import org.ovirt.engine.core.common.businessentities.storage.BaseDisk; Please sort the imports. Line 8: import org.ovirt.engine.core.common.businessentities.DiskInterface; Line 9: import org.ovirt.engine.core.common.businessentities.PropagateErrors; Line 10: import org.ovirt.engine.core.common.businessentities.ScsiGenericIO; Line 11: import org.ovirt.engine.core.compat.Guid; https://gerrit.ovirt.org/#/c/38650/1/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java: Line 14: import javax.sql.DataSource; Line 15: Line 16: import org.junit.Test; Line 17: import org.ovirt.engine.core.common.VdcObjectType; Line 18: import org.ovirt.engine.core.common.businessentities.storage.BaseDisk; Please sort the imports. Line 19: import org.ovirt.engine.core.common.businessentities.Bookmark; Line 20: import org.ovirt.engine.core.common.businessentities.Permissions; Line 21: import org.ovirt.engine.core.common.businessentities.Quota; Line 22: import org.ovirt.engine.core.common.businessentities.Role; https://gerrit.ovirt.org/#/c/38650/1/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java: Line 9: import java.util.List; Line 10: Line 11: import org.junit.Test; Line 12: import org.ovirt.engine.core.common.businessentities.ActionGroup; Line 13: import org.ovirt.engine.core.common.businessentities.storage.BaseDisk; Please sort the imports. Line 14: import org.ovirt.engine.core.common.businessentities.StorageDomain; Line 15: import org.ovirt.engine.core.common.businessentities.StorageDomainStatic; Line 16: import org.ovirt.engine.core.common.businessentities.StorageDomainStatus; Line 17: import org.ovirt.engine.core.common.businessentities.StorageDomainType; https://gerrit.ovirt.org/#/c/38650/1/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml File frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml: Line 26: <include name="aaa/DirectoryUser.java" /> Line 27: <include name="aaa/Managed.java" /> Line 28: <include name="common/businessentities/AuditLog.java" /> Line 29: <include name="common/businessentities/Bookmark.java" /> Line 30: <include name="common/businessentities/storage/BaseDisk.java" /> Please sort this Line 31: <include name="common/businessentities/CommandEntity.java" /> Line 32: <include name="common/businessentities/DiskLunMap.java" /> Line 33: <include name="common/businessentities/DiskLunMapId.java" /> Line 34: <include name="common/businessentities/Disk.java" /> -- To view, visit https://gerrit.ovirt.org/38650 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54f304e2453ea0acd773a891e651190a3093eccc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Fred Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
