Moti Asayag has uploaded a new change for review.
Change subject: engine: Reduce need for constant casting
......................................................................
engine: Reduce need for constant casting
By generics we can simplify the usage of the CoCo util
and avoid constant casting by the clients.
Change-Id: Iee9caa732a0a2d84889d9dd6d0e0a4e5e06397c8
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommandCallback.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommandCallback.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java
6 files changed, 8 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/67/38667/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java
index e6654b2..e564be3 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java
@@ -51,6 +51,6 @@
}
private MergeCommand<MergeParameters> getCommand(Guid cmdId) {
- return (MergeCommand<MergeParameters>)
CommandCoordinatorUtil.retrieveCommand(cmdId);
+ return CommandCoordinatorUtil.retrieveCommand(cmdId);
}
}
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommandCallback.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommandCallback.java
index c3e1087..57a4e7c 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommandCallback.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommandCallback.java
@@ -14,6 +14,6 @@
}
private MergeStatusCommand<MergeParameters> getCommand(Guid cmdId) {
- return (MergeStatusCommand<MergeParameters>)
CommandCoordinatorUtil.retrieveCommand(cmdId);
+ return CommandCoordinatorUtil.retrieveCommand(cmdId);
}
}
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java
index 66c9f04..63893d5 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java
@@ -66,6 +66,6 @@
}
private RemoveDiskSnapshotsCommand<RemoveDiskSnapshotsParameters>
getCommand(Guid cmdId) {
- return (RemoveDiskSnapshotsCommand<RemoveDiskSnapshotsParameters>)
CommandCoordinatorUtil.retrieveCommand(cmdId);
+ return CommandCoordinatorUtil.retrieveCommand(cmdId);
}
}
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java
index 9a5e8df..b0a2d46 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java
@@ -52,6 +52,6 @@
}
private RemoveSnapshotCommand<RemoveSnapshotParameters> getCommand(Guid
cmdId) {
- return (RemoveSnapshotCommand<RemoveSnapshotParameters>)
CommandCoordinatorUtil.retrieveCommand(cmdId);
+ return CommandCoordinatorUtil.retrieveCommand(cmdId);
}
}
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommandCallback.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommandCallback.java
index f2ac0bd..6d6aac9 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommandCallback.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommandCallback.java
@@ -24,6 +24,6 @@
}
private
RemoveSnapshotSingleDiskLiveCommand<RemoveSnapshotSingleDiskParameters>
getCommand(Guid cmdId) {
- return
(RemoveSnapshotSingleDiskLiveCommand<RemoveSnapshotSingleDiskParameters>)
CommandCoordinatorUtil.retrieveCommand(cmdId);
+ return CommandCoordinatorUtil.retrieveCommand(cmdId);
}
}
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java
index 467fc79..f6ea808 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java
@@ -148,8 +148,9 @@
return coco.getCommandEntity(commandId);
}
- public static CommandBase<?> retrieveCommand(Guid commandId) {
- return coco.retrieveCommand(commandId);
+ @SuppressWarnings("unchecked")
+ public static <C extends CommandBase<?>> C retrieveCommand(Guid commandId)
{
+ return (C) coco.retrieveCommand(commandId);
}
public static void removeCommand(Guid commandId) {
--
To view, visit https://gerrit.ovirt.org/38667
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee9caa732a0a2d84889d9dd6d0e0a4e5e06397c8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
