Greg Sheremeta has uploaded a new change for review.

Change subject: userportal, webadmin: CellWithElementId comment cleanup
......................................................................

userportal, webadmin: CellWithElementId comment cleanup

(Patch 4o of 12)

Change-Id: I89a67ab19279d00b8f88b3d5ec1152b0cda69101
Signed-off-by: Greg Sheremeta <gsher...@redhat.com>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/idhandler/CellWithElementId.java
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/21/38621/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/idhandler/CellWithElementId.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/idhandler/CellWithElementId.java
index 6be8420..84425cf 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/idhandler/CellWithElementId.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/idhandler/CellWithElementId.java
@@ -2,11 +2,9 @@
 
 import com.google.gwt.cell.client.Cell;
 
-// TODO I think all of our custom cells should implement this. No reason
-// not to have IDs on every table cell.
-
 /**
  * A cell that sets an ID when it renders.
+ * TODO All of our custom cells should implement this.
  *
  * @param <C>
  *            Cell data type.
@@ -25,7 +23,13 @@
      */
     public void setColumnId(String columnId);
 
+    /**
+     * Get the element id prefix.
+     */
     public String getElementIdPrefix();
 
+    /**
+     * Get the column id.
+     */
     public String getColumnId();
 }


-- 
To view, visit https://gerrit.ovirt.org/38621
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I89a67ab19279d00b8f88b3d5ec1152b0cda69101
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to