Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Restore volume snapshot with georep case ......................................................................
Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/38150/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeSnapshotCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeSnapshotCommandBase.java: Line 18: Line 19: @Override Line 20: public Map<String, String> getCustomValues() { Line 21: Map<String, String> map = new HashMap<>(); Line 22: map.put(GlusterConstants.VOLUME_SNAPSHOT_NAME, getParameters().getSnapshotName()); > addCustomValue(GlusterConstants.VOLUME_SNAPSHOT_NAME, getParameters().getSn done Line 23: return map; Line 24: } Line 25: Line 26: @Override Line 24: } Line 25: Line 26: @Override Line 27: protected void setActionMessageParameters() { Line 28: addCustomValue(GlusterConstants.VOLUME_SNAPSHOT_NAME, getParameters().getSnapshotName()); > canDoActionMessage related here? This is not required I feel. Will remove that and verify. Line 29: } Line 30: Line 31: @Override Line 32: protected boolean canDoAction() { https://gerrit.ovirt.org/#/c/38150/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RestoreGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RestoreGlusterVolumeSnapshotCommand.java: Line 200: Boolean tranRetVal = TransactionSupport.executeInNewTransaction(new TransactionMethod<Boolean>() { Line 201: @Override Line 202: public Boolean runInTransaction() { Line 203: // Pause the geo-replication session Line 204: if (!stopGeoReplicationSessions(georepSessions)) { > check if geoRepSessions has been initialised correctly done Line 205: return false; Line 206: } Line 207: Line 208: // Stop the slave volumes Line 228: if (!georepSessions.isEmpty()) { Line 229: handleVdsError(AuditLogType.GLUSTER_MASTER_VOLUME_STOP_FAILED_DURING_SNAPSHOT_RESTORE, Line 230: "Failed to stop the master volume while restoring the snapshot, " Line 231: + "whereas slave volume(s) are restored to older state. " Line 232: + "Admin should manually inetrevene and set the stime in master to proper value and resume the geo-replication session"); > Externalize this string? done Line 233: } Line 234: return; Line 235: } Line 236: -- To view, visit https://gerrit.ovirt.org/38150 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0eccbcd4aa3e218ba0d910bd9150bdb0baa2db68 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
