Alon Bar-Lev has posted comments on this change. Change subject: WIP: allow to deploy hosted-engine from UX ......................................................................
Patch Set 1: (4 comments) config file? https://gerrit.ovirt.org/#/c/38547/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-03-10 16:30:01 +0100 Line 4: Commit: Sandro Bonazzola <sbona...@redhat.com> Line 5: CommitDate: 2015-03-10 16:56:30 +0100 Line 6: Line 7: WIP: allow to deploy hosted-engine from UX hosted-engine: xxx Line 8: Line 9: - install/update ovirt-hosted-engine-setup Line 10: Line 11: Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 https://gerrit.ovirt.org/#/c/38547/1/ChangeLog File ChangeLog: Line 1 Line 2 Line 3 Line 4 please keep the space https://gerrit.ovirt.org/#/c/38547/1/src/plugins/ovirt-host-deploy/hosted-engine/Makefile.am File src/plugins/ovirt-host-deploy/hosted-engine/Makefile.am: Line 22: MAINTAINERCLEANFILES = \ Line 23: $(srcdir)/Makefile.in \ Line 24: $(NULL) Line 25: Line 26: mydir=$(ovirthostdeployplugindir)/ovirt-host-deploy/gluster gluster-> Line 27: dist_my_PYTHON = \ Line 28: __init__.py \ Line 29: packages.py \ Line 30: $(NULL) https://gerrit.ovirt.org/#/c/38547/1/src/plugins/ovirt-host-deploy/hosted-engine/packages.py File src/plugins/ovirt-host-deploy/hosted-engine/packages.py: Line 63: ), Line 64: ) Line 65: def _validation(self): Line 66: if not self.packager.queryPackages( Line 67: patterns=('ovirt-hosted-engine-setup',) you need to add this in the offline packager as well if you check, I am unsure this check is required, as we will fail installation. Line 68: ): Line 69: raise RuntimeError( Line 70: _( Line 71: 'Cannot locate Hosted Engine packages, ' -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
