anmolbabu has posted comments on this change. Change subject: webadmin : GeoRep Config popup view ......................................................................
Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/34217/14/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java: Line 325: actionTypes.add(VdcActionType.SetGeoRepConfig); Line 326: parameters.add(geoRepConfigModel.formGeoRepConfigParameters(newConfig)); Line 327: } Line 328: } Line 329: n = parameters.size(); > You don't need variable n here. Simply paremters.size() can be used. If u s Done Line 330: callbacks = new IFrontendActionAsyncCallback[n]; Line 331: callbacks[n - 1] = new IFrontendActionAsyncCallback() { Line 332: @Override Line 333: public void executed(FrontendActionAsyncResult result) { -- To view, visit https://gerrit.ovirt.org/34217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I150946fe016d85cb378ed3d548eab5581321fbfe Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
