Greg Sheremeta has uploaded a new change for review.
Change subject: webadmin: deleted redundant class
AbstractTextColumnWithEditableTooltip
......................................................................
webadmin: deleted redundant class AbstractTextColumnWithEditableTooltip
(Patch 4c of 12)
Change-Id: I5ff0399cbd21680ee7707b7f0702352314673122
Signed-off-by: Greg Sheremeta <gsher...@redhat.com>
---
D
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCellWithEditableTooltip.java
D
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractTextColumnWithEditableTooltip.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java
3 files changed, 6 insertions(+), 75 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/08/38608/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCellWithEditableTooltip.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCellWithEditableTooltip.java
deleted file mode 100644
index c8e0d5d..0000000
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCellWithEditableTooltip.java
+++ /dev/null
@@ -1,39 +0,0 @@
-package org.ovirt.engine.ui.common.widget.table.cell;
-
-import com.google.gwt.cell.client.Cell;
-import com.google.gwt.cell.client.ValueUpdater;
-import com.google.gwt.dom.client.BrowserEvents;
-import com.google.gwt.dom.client.Element;
-import com.google.gwt.dom.client.NativeEvent;
-
-/**
- * This Cell type allows you to edit the text that would be presented as
tooltip.
- * It overrides the usual {@link TextCellWithTooltip} tooltip behavior
- */
-public class TextCellWithEditableTooltip extends TextCellWithTooltip {
-
- private String title = ""; //$NON-NLS-1$
-
- public TextCellWithEditableTooltip() {
- super(TextCellWithTooltip.UNLIMITED_LENGTH);
- }
-
- @Override
- public void onBrowserEvent(Cell.Context context, Element parent,
- String value, NativeEvent event,
ValueUpdater<String> valueUpdater) {
- super.onBrowserEvent(context, parent, value, event, valueUpdater);
-
- // Ignore events other than 'mouseover' or when title was left empty
string
- if (!BrowserEvents.MOUSEOVER.equals(event.getType()) ||
"".equals(title)) { //$NON-NLS-1$
- return;
- }
-
- parent.setTitle(title);
- }
-
- @Override
- public void setTitle(String title) {
- this.title = title != null ? title : ""; //$NON-NLS-1$
- }
-
-}
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractTextColumnWithEditableTooltip.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractTextColumnWithEditableTooltip.java
deleted file mode 100644
index e7fa438..0000000
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractTextColumnWithEditableTooltip.java
+++ /dev/null
@@ -1,29 +0,0 @@
-package org.ovirt.engine.ui.common.widget.table.column;
-
-import
org.ovirt.engine.ui.common.widget.table.cell.TextCellWithEditableTooltip;
-
-
-/**
- * Column for displaying text using {@link TextCellWithEditableTooltip}.
- *
- * @param <T>
- * Table row data type.
- */
-public abstract class AbstractTextColumnWithEditableTooltip<T> extends
AbstractSortableColumn<T, String>
- implements ColumnWithElementId {
-
- public AbstractTextColumnWithEditableTooltip() {
- super(new TextCellWithEditableTooltip());
- }
-
- @Override
- public void configureElementId(String elementIdPrefix, String columnId) {
- getCell().setElementIdPrefix(elementIdPrefix);
- getCell().setColumnId(columnId);
- }
-
- @Override
- public TextCellWithEditableTooltip getCell() {
- return (TextCellWithEditableTooltip) super.getCell();
- }
-}
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java
index 7fd5e52..7c6b9cd 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java
@@ -10,8 +10,7 @@
import org.ovirt.engine.ui.common.idhandler.ElementIdHandler;
import org.ovirt.engine.ui.common.uicommon.model.SearchableDetailModelProvider;
import org.ovirt.engine.ui.common.widget.renderer.DiskSizeRenderer;
-import
org.ovirt.engine.ui.common.widget.table.cell.TextCellWithEditableTooltip;
-import
org.ovirt.engine.ui.common.widget.table.column.AbstractTextColumnWithEditableTooltip;
+import org.ovirt.engine.ui.common.widget.table.cell.TextCellWithTooltip;
import org.ovirt.engine.ui.common.widget.table.column.AbstractTextColumn;
import org.ovirt.engine.ui.uicommonweb.models.quota.QuotaListModel;
import org.ovirt.engine.ui.uicommonweb.models.quota.QuotaStorageListModel;
@@ -58,7 +57,7 @@
nameColumn.makeSortable();
getTable().addColumn(nameColumn, constants.nameQuotaStorage(),
"400px"); //$NON-NLS-1$
- AbstractTextColumnWithEditableTooltip<QuotaStorage> usedColumn = new
AbstractTextColumnWithEditableTooltip<QuotaStorage>() {
+ AbstractTextColumn<QuotaStorage> usedColumn = new
AbstractTextColumn<QuotaStorage>() {
@Override
public String getValue(QuotaStorage object) {
if (object.getStorageSizeGB() == null) {
@@ -76,10 +75,10 @@
}
@Override
- public TextCellWithEditableTooltip getCell() {
- TextCellWithEditableTooltip textCellWithEditableTooltip =
super.getCell();
-
textCellWithEditableTooltip.setTitle(constants.quotaCalculationsMessage());
- return textCellWithEditableTooltip;
+ public TextCellWithTooltip getCell() {
+ TextCellWithTooltip TextCellWithTooltip = super.getCell();
+
TextCellWithTooltip.setTitle(constants.quotaCalculationsMessage());
+ return TextCellWithTooltip;
}
};
usedColumn.makeSortable(new Comparator<QuotaStorage>() {
--
To view, visit https://gerrit.ovirt.org/38608
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ff0399cbd21680ee7707b7f0702352314673122
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
