Amit Aviram has posted comments on this change. Change subject: webadmin: Disabling unsupported storage types when adding a domain. ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38544/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 2815: switch (type) { Line 2816: case GLUSTERFS: Line 2817: return (Boolean) getConfigValuePreConverted(ConfigurationValues.GlusterFsStorageEnabled , compatibilityVersion.toString()); Line 2818: case POSIXFS: Line 2819: return (Boolean) getConfigValuePreConverted(ConfigurationValues.PosixStorageEnabled , compatibilityVersion.toString()); > This is OK for now, but we need a better mechanism. You're right, Done. Line 2820: } Line 2821: Line 2822: // Every other type fits all DC versions. Line 2823: return true; -- To view, visit https://gerrit.ovirt.org/38544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fcc131454e0722fbf8d6e84607a71381e1d04fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
