Sahina Bose has posted comments on this change. Change subject: engine: Changes to brick sync for storage network ......................................................................
Patch Set 6: (2 comments) Patchset to follow https://gerrit.ovirt.org/#/c/38148/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java: Line 33: import org.ovirt.engine.core.common.businessentities.network.VdsNetworkInterface; Line 34: import org.ovirt.engine.core.common.constants.gluster.GlusterConstants; Line 35: import org.ovirt.engine.core.common.gluster.GlusterFeatureSupported; Line 36: import org.ovirt.engine.core.common.utils.ListUtils; Line 37: import org.ovirt.engine.core.common.utils.ObjectUtils; > in bll we can use java.util.Objects.equals() Done Line 38: import org.ovirt.engine.core.common.utils.gluster.GlusterCoreUtil; Line 39: import org.ovirt.engine.core.common.vdscommands.RemoveVdsVDSCommandParameters; Line 40: import org.ovirt.engine.core.common.vdscommands.VDSCommandType; Line 41: import org.ovirt.engine.core.common.vdscommands.VDSReturnValue; https://gerrit.ovirt.org/#/c/38148/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java: Line 198: log.warn("Could not add brick '{}' to volume '{}' - server uuid '{}' not found in cluster '{}'", brickName, volumeId, hostUuid, clusterId); Line 199: return null; Line 200: } Line 201: VdsStatic server = DbFacade.getInstance().getVdsStaticDao().get(glusterServer.getId()); Line 202: String networkAddress = null; > what's the point in using 'networkAddress' ? isn't hostAddress enough ? brickname is of the form <ipaddress/hostname>:<mount point path> networkAddress is to be passed in case the ipaddress/hostname of the brick is not equal to the host's hostname, and if it matches the gluster network on the host. Otherwise, networkAddress will be passed as null Line 203: Guid networkId = null; Line 204: if (!server.getHostName().equals(hostAddress)) { Line 205: networkAddress = hostAddress; Line 206: Network network = getGlusterNetworkId(server, networkAddress); -- To view, visit https://gerrit.ovirt.org/38148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99f1ed0d9718be79ffac2ac04a36999c93a79ef2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
