Martin Peřina has uploaded a new change for review. Change subject: core: Test for empty id when saving new permission ......................................................................
core: Test for empty id when saving new permission Replaces Guid.EMPTY in Permissions.id when saving new permission into database. Change-Id: I9617cf0ca558730bce9bf9e3209f472859b42664 Bug-Url: https://bugzilla.redhat.com/1195119 Signed-off-by: Martin Perina <mper...@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/75/38575/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java index 9a76779..ed1544f 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java @@ -219,7 +219,8 @@ public void save(Permissions permission) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() .addValue("ad_element_id", permission.getad_element_id()) - .addValue("id", permission.getId()) + .addValue("id", + Guid.Empty.equals(permission.getId()) ? Guid.newGuid() : permission.getId()) .addValue("role_id", permission.getrole_id()) .addValue("object_id", permission.getObjectId()) .addValue("object_type_id", -- To view, visit https://gerrit.ovirt.org/38575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9617cf0ca558730bce9bf9e3209f472859b42664 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
