Oved Ourfali has uploaded a new change for review. Change subject: core: Set Guid.EMPTY to Permissions.id by default ......................................................................
core: Set Guid.EMPTY to Permissions.id by default Sets Guid.EMPTY to Permissions.id by default when creating new instance because: 1. Guid.newGuid() cannot be used in frontend code, because it call UUID.randomUUID() which is not supported in GWT 2. In AddPermission command there's always assigned Guid.newGuid() into Permissions.id for created permissions. Change-Id: I35aad0115394fde0bf30a27b3eb47c46496bd821 Bug-Url: https://bugzilla.redhat.com/1195119 Signed-off-by: Martin Perina <mper...@redhat.com> (cherry picked from commit f3c71e1197a0ea1906539162ae19057ff4021b3d) (cherry picked from commit f877373820ba64d39497f23f39015fe186a7bff9) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/69/38569/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java index affb90a..cef11ae 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java @@ -25,7 +25,7 @@ } public Permissions(Guid adElementId, Guid roleId, Guid objectId, VdcObjectType objectType) { - this.id = Guid.newGuid(); + this.id = Guid.Empty; this.adElementId = adElementId; this.roleId = roleId; this.objectId = objectId; -- To view, visit https://gerrit.ovirt.org/38569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I35aad0115394fde0bf30a27b3eb47c46496bd821 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
