Ramesh N has posted comments on this change. Change subject: engine: vds commands for gluster brick create ......................................................................
Patch Set 11: (2 comments) I will handle the exception raised for glusterCreatebrick verb from VDSM https://gerrit.ovirt.org/#/c/35498/. Patch set to follow. https://gerrit.ovirt.org/#/c/36029/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1614: return new StorageDeviceListReturnForXmlRpc(response); Line 1615: } Line 1616: Line 1617: @Override Line 1618: public OneStorageDeviceReturnForXmlRpc createBrick(String lvName, > Please follow convention and change method name to glusterCreateBrick. Done Line 1619: String mountPoint, Line 1620: Map<String, Object> raidParams, Line 1621: String[] storageDevices) { Line 1622: JsonRpcRequest request = new RequestBuilder("GlusterHost.createBrick").withParameter("brickName", lvName) https://gerrit.ovirt.org/#/c/36029/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java: Line 344: StatusOnlyReturnForXmlRpc glusterVolumeGeoRepResume(String volumeName, String slaveHostName, String slaveVolumeName, boolean force); Line 345: Line 346: VMListReturnForXmlRpc getExternalVmList(String uri, String username, String password); Line 347: Line 348: OneStorageDeviceReturnForXmlRpc createBrick(String lvName, String mountPoint, Map<String, Object> raidParams, > call it glusterHostCreateBrick? Changing it glusterCreateBrick as suggested by Piotr. Line 349: String[] array); -- To view, visit https://gerrit.ovirt.org/36029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a74a9eeabd19b9780e4401d263e586261f488d Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
