Shubhendu Tripathi has posted comments on this change. Change subject: engine,webadmin: Add an indicator if geo-replication is enabled ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/38310/5/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeInfoCell.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeInfoCell.java: Line 13: import com.google.gwt.safehtml.shared.SafeHtmlBuilder; Line 14: import com.google.gwt.safehtml.shared.SafeHtmlUtils; Line 15: import com.google.gwt.user.client.ui.AbstractImagePrototype; Line 16: Line 17: public class VolumeInfoCell extends AbstractCell<GlusterVolumeEntity> { > Any reason why activities column is not used? Activities column is meant for showing the status of ongoing activities like rebalnce and remove brick. Whereas we need to indicate if geo-replication is setup for the volume or snapshots scheduled for the volume and for this we need another column, so introduced one as Info. Line 18: Line 19: private static final ApplicationResources resources = GWT.create(ApplicationResources.class); Line 20: private static final ApplicationConstants constants = GWT.create(ApplicationConstants.class); Line 21: private static final ApplicationTemplates applicationTemplates = GWT.create(ApplicationTemplates.class); -- To view, visit https://gerrit.ovirt.org/38310 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28178b8ef03ea7cc83097cb99bc2d2be90061434 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
