Moti Asayag has posted comments on this change. Change subject: engine: Enhance brick to support storage network ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/37558/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java: Line 40: public abstract class GlusterCommandBase<T extends VdcActionParametersBase> extends CommandBase<T> { Line 41: protected AuditLogType errorType; Line 42: protected VDS upServer; Line 43: private Network glusterNetwork; Line 44: private Boolean hasGlusterNetwork = true; 1. it can be primitive according to the use of it. 2. why is it required ? if getGlusterNetwork() returns null, there is no re-attempt to fetch it again. Line 45: Line 46: public GlusterCommandBase(T params) { Line 47: this(params, null); Line 48: } https://gerrit.ovirt.org/#/c/37558/9/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 3024: INNER JOIN vds_static ON vds_static.vds_id = gluster_volume_bricks.server_id Line 3025: INNER JOIN gluster_volumes ON gluster_volumes.id = gluster_volume_bricks.volume_id Line 3026: LEFT OUTER JOIN network on network.id = gluster_volume_bricks.network_id Line 3027: LEFT OUTER JOIN vds_interface ON vds_interface.vds_id = gluster_volume_bricks.server_id Line 3028: AND vds_interface.network_name = network.name; when the new host network api is merged (probably in couple of months) - this could be simplified by using the network_attachments table which matches nic-id to network-id Line 3029: Line 3030: CREATE Line 3031: OR REPLACE VIEW gluster_volume_task_steps AS Line 3032: SELECT -- To view, visit https://gerrit.ovirt.org/37558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9749febf721172a09ddce756c0eeb745a9502e1a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
