Moti Asayag has uploaded a new change for review.
Change subject: engine: Remove useless injected dao
......................................................................
engine: Remove useless injected dao
The injected dao isn't being used within this been,
hence it should be removed.
Change-Id: Ida1b0803fe94cac38120788af9ef7b78de4d1a6d
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkClusterPermissionsChecker.java
1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/31/38531/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkClusterPermissionsChecker.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkClusterPermissionsChecker.java
index 20a0dbc..f5fd1b1 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkClusterPermissionsChecker.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkClusterPermissionsChecker.java
@@ -2,9 +2,7 @@
import java.util.ArrayList;
import java.util.List;
-import java.util.Objects;
-import javax.inject.Inject;
import javax.inject.Singleton;
import org.ovirt.engine.core.bll.CommandBase;
@@ -13,19 +11,9 @@
import org.ovirt.engine.core.common.action.VdcActionType;
import org.ovirt.engine.core.common.businessentities.network.NetworkCluster;
import org.ovirt.engine.core.compat.Guid;
-import org.ovirt.engine.core.dao.network.NetworkClusterDao;
@Singleton
class AttachNetworkClusterPermissionsChecker {
-
- private final NetworkClusterDao networkClusterDao;
-
- @Inject
- AttachNetworkClusterPermissionsChecker(NetworkClusterDao
networkClusterDao) {
- Objects.requireNonNull(networkClusterDao, "networkClusterDao cannot be
null");
-
- this.networkClusterDao = networkClusterDao;
- }
public boolean checkPermissions(CommandBase<?> command,
List<PermissionSubject> permissionCheckSubjects) {
final List<String> messages = new ArrayList<>();
--
To view, visit https://gerrit.ovirt.org/38531
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida1b0803fe94cac38120788af9ef7b78de4d1a6d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
