Sahina Bose has posted comments on this change. Change subject: gluster: Corrected VDS commands as per latest VDSM verbs ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38498/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1655: return new GlusterVolumeSnapshotInfoReturnForXmlRpc(clusterId, response); Line 1656: } Line 1657: Line 1658: @Override Line 1659: public GlusterVolumeSnapshotConfigReturnForXmlRpc glusterVolumeSnapshotConfigGet(Guid clusterId, String volumeName) { > Yes with new changes its not used, as we always call this for whole cluster Yes, please change the method signature in that case Line 1660: JsonRpcRequest request = Line 1661: new RequestBuilder("GlusterSnapshot.configList").build(); Line 1662: Map<String, Object> response = new FutureMap(this.client, request).withIgnoreResponseKey(); Line 1663: return new GlusterVolumeSnapshotConfigReturnForXmlRpc(clusterId, response); -- To view, visit https://gerrit.ovirt.org/38498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief9bcdf7d05f5d4e0bb54a3163ec27c57ccf81e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
