Tomas Jelinek has posted comments on this change. Change subject: webadmin: Changes in disk popup needed to reuse in VM popup ......................................................................
Patch Set 16: (2 comments) https://gerrit.ovirt.org/#/c/36061/16/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java: Line 59: new GetDisksCallback(DiskStorageType.LUN)); Line 60: } Line 61: Line 62: protected void doLoadAttachableDisks(GetDisksCallback imageCallback, GetDisksCallback lunCallback) { Line 63: AsyncDataProvider.getInstance().getAllAttachableDisks( > is it relevant to the change or just a refactoring? well, it is generalized so I could use it without much copy-paste in this feature. So it was a refactoring needed to be able to make the relevant change :) Line 64: new AsyncQuery(this, imageCallback Line 65: ), getVm().getStoragePoolId(), getVm().getId()); Line 66: Line 67: // Get external attachable disks Line 63: AsyncDataProvider.getInstance().getAllAttachableDisks( Line 64: new AsyncQuery(this, imageCallback Line 65: ), getVm().getStoragePoolId(), getVm().getId()); Line 66: Line 67: // Get external attachable disks > i guess the comment can be removed now, or add to the previous one the othe removed Line 68: AsyncDataProvider.getInstance().getAllAttachableDisks( Line 69: new AsyncQuery(this, lunCallback Line 70: ), null, getVm().getId()); Line 71: } -- To view, visit https://gerrit.ovirt.org/36061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52c5d5c7b83dd53cea3a9419656015e6a51bd179 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Candace Sheremeta <csher...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
